[LUCENE-1653] Change DateTools to not create a Calendar in every call to dateToString or timeToString

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.9
• Component/s: core/other
• Lucene Fields: New, Patch Available
• Assignee: Mark Miller
• Reporter: Shai Erera
• Created: 21/May/09 20:54
• Updated: 28/Aug/22 12:01
• Resolved: 28/May/09 12:03

Description

DateTools creates a Calendar instance on every call to dateToString and timeToString. Specifically:

1. timeToString calls Calendar.getInstance on every call.
2. dateToString calls timeToString(date.getTime()), which then instantiates a new Date(). I think we should change the order of the calls, or not have each call the other.
3. round(), which is called from timeToString (after creating a Calendar instance) creates another Calendar instance ...

Seems that if we synchronize the methods and create the Calendar instance once (static), it should solve it.