Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1650

Small fix in CustomScoreQuery JavaDoc

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • 4.9, 6.0
    • general/javadocs
    • New, Patch Available

    Description

      I have fixed the javadoc for "Modified Score" formular in CustomScoreQuery. - Patch attached: customScoreQuery_JavaDoc.patch

      I'm quite curious why the method:
      public float customScore(int doc, float subQueryScore, float valSrcScores[])

      calls public float customScore(int doc, float subQueryScore, float valSrcScore]) only in 2 of the 3 cases which makes the choice to override either one of the customScore methods dependent on the number of ValueSourceQuery passed to the constructor. I figure it would be more consistent if it would call the latter in all 3 cases.

      I also attached a patch which proposes a fix for that issue. The patch does also include the JavaDoc issue mentioned above.

      • customScoreQuery_CodeChange+JavaDoc.patch

      Attachments

        1. LUCENE-1650.patch
          4 kB
          Mark Miller
        2. LUCENE-1650.patch
          4 kB
          Mark Miller
        3. customScoreQuery_JavaDoc.patch
          0.6 kB
          Simon Willnauer
        4. customScoreQuery_CodeChange+JavaDoc.patch
          2 kB
          Simon Willnauer

        Activity

          People

            Unassigned Unassigned
            simonwillnauer Simon Willnauer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: