Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1611

Do not launch new merges if IndexWriter has hit OOME

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.9
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      if IndexWriter has hit OOME, it defends itself by refusing to commit changes to the index, including merges. But this can lead to infinite merge attempts because we fail to prevent starting a merge.

      Spinoff from http://www.nabble.com/semi-infinite-loop-during-merging-td23036156.html.

      1. LUCENE-1611.patch
        8 kB
        Michael McCandless
      2. LUCENE-1611.patch
        3 kB
        Michael McCandless
      3. LUCENE-1611-241.patch
        3 kB
        Michael McCandless

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        Attached patch to prevent starting new merges after OOME, and to throw IllegalStateException in optimize, expungeDeletes if OOME is hit. I plan to commit in a day or two.

        Show
        mikemccand Michael McCandless added a comment - Attached patch to prevent starting new merges after OOME, and to throw IllegalStateException in optimize, expungeDeletes if OOME is hit. I plan to commit in a day or two.
        Hide
        mikemccand Michael McCandless added a comment -

        Attached 2.4.1 patch.

        Show
        mikemccand Michael McCandless added a comment - Attached 2.4.1 patch.
        Hide
        mikemccand Michael McCandless added a comment -

        New patch that fixes a few issues Christiaan found. I think this is ready to commit... I'll wait a few hours.

        Show
        mikemccand Michael McCandless added a comment - New patch that fixes a few issues Christiaan found. I think this is ready to commit... I'll wait a few hours.
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks Christiaan!

        Show
        mikemccand Michael McCandless added a comment - Thanks Christiaan!

          People

          • Assignee:
            mikemccand Michael McCandless
            Reporter:
            mikemccand Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development