Lucene - Core
  1. Lucene - Core
  2. LUCENE-1610

Preserve whitespace in <code> sections in the Changes.html generated from CHANGES.txt by changes2html.pl

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: general/website
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The Trunk section of CHANGES.txt sports use of a new feature: <code> sections, for the two mentions of LUCENE-1575.

      This looks fine in the text rendering, but looks crappy in the HTML version, since changes2html.pl escapes HTML metacharacters to appear as-is in the HTML rendering, but the newlines in the code are converted to a single space.

      I think this should be fixed by modifying changes2html.pl to convert <code> and </code> into (unescaped) <code><pre> and </pre></code>, respectively, since just passing through <code> and </code>, without </?pre>, while changing the font to monospaced (nice), still collapses whitespace (not nice).

      See the java-dev thread that spawned this issue here: http://www.nabble.com/CHANGES.txt-td23102627.html

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1h 5m 1 Michael McCandless 24/Apr/09 22:21
        Resolved Resolved Closed Closed
        153d 18h 1m 1 Mark Miller 25/Sep/09 16:23
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12562878 ] jira [ 12583947 ]
        Mark Thomas made changes -
        Workflow jira [ 12461707 ] Default workflow, editable Closed status [ 12562878 ]
        Mark Miller made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Michael McCandless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Michael McCandless added a comment -

        Thanks Steve!

        Show
        Michael McCandless added a comment - Thanks Steve!
        Steve Rowe made changes -
        Field Original Value New Value
        Attachment LUCENE-1610.patch [ 12406400 ]
        Hide
        Steve Rowe added a comment -

        Implements the suggested fix: <code> is converted to <code><pre> (instead of to &lt;code&gt; ) and </code> is converted to </pre></code> (instead of to &lt;/code&gt; )

        Show
        Steve Rowe added a comment - Implements the suggested fix: <code> is converted to <code><pre> (instead of to &lt;code&gt; ) and </code> is converted to </pre></code> (instead of to &lt;/code&gt; )
        Steve Rowe created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Steve Rowe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development