[LUCENE-1552] IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4
• Fix Version/s: 2.4.1, 2.9

Environment

Java

• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Scott Garland
• Created: 04/Mar/09 20:40
• Updated: 28/Aug/22 11:58
• Resolved: 09/Mar/09 10:37

Description

After this bit of code in addIndexes(IndexReader[] readers)

try

{ flush(true, false, true); optimize(); // start with zero or 1 seg success = true; }

finally

{ // Take care to release the write lock if we hit an // exception before starting the transaction if (!success) releaseWrite(); }

The success flag should be reset to "false" because it's used again in another try/catch/finally block.

TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.