Lucene - Core
  1. Lucene - Core
  2. LUCENE-1469

isValid should be invoked after analyze rather than before it so it can validate the output of analyze

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: modules/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The Synonym map has a protected method String analyze(String word) designed for custom stemming.

      However, before analyze is invoked on a word, boolean isValid(String str) is used to validate the word - which causes the program to discard words that maybe useable by the custom analyze method.

      I think that isValid should be invoked after analyze rather than before it so it can validate the output of analyze and allow implemters to decide what is valid for the overridden analyze method. (In fact, if you look at code snippet below, isValid should really go after the empty string check)

      This is a two line change in org.apache.lucene.index.memory.SynonymMap

      /*

      • Part B: ignore phrases (with spaces and hyphens) and
      • non-alphabetic words, and let user customize word (e.g. do some
      • stemming)
        */
        if (!isValid(word)) continue; // ignore
        word = analyze(word);
        if (word == null || word.length() == 0) continue; // ignore

        Activity

        Vincent Li created issue -
        Shai Erera made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.1 [ 12314822 ]
        Fix Version/s 4.0 [ 12314025 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12446957 ] Default workflow, editable Closed status [ 12562419 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12562419 ] jira [ 12584764 ]
        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Vincent Li
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5m
              5m
              Remaining:
              Remaining Estimate - 5m
              5m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development