Lucene - Core
  1. Lucene - Core
  2. LUCENE-1467

Consolidate Solr's and Lucene's OpenBitSet classes

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      See SOLR-875 for details.

      1. lucene-1467.patch
        6 kB
        Michael Busch

        Issue Links

          Activity

          Hide
          Michael Busch added a comment -

          Simple patch that adds two methods to OpenBitSetIterator: nextDoc() and next(int). These work just as next() and skipTo(int) with the difference that they return the new docId instead of true/false.

          Also improves the unit tests to test the new methods and moves testBitUtils() from Solr into Lucene.

          All tests pass. I'm planning to commit this in a day or so.

          Show
          Michael Busch added a comment - Simple patch that adds two methods to OpenBitSetIterator: nextDoc() and next(int). These work just as next() and skipTo(int) with the difference that they return the new docId instead of true/false. Also improves the unit tests to test the new methods and moves testBitUtils() from Solr into Lucene. All tests pass. I'm planning to commit this in a day or so.
          Hide
          Michael McCandless added a comment -

          Michael, what do nextDoc() and next(int) return when there are no more docs (ie the iterator is done)?

          Show
          Michael McCandless added a comment - Michael, what do nextDoc() and next(int) return when there are no more docs (ie the iterator is done)?
          Hide
          Michael Busch added a comment -

          They return -1. next(int) has a comment which states that, I will make it clearer in the javadocs of nextDoc().

          Show
          Michael Busch added a comment - They return -1. next(int) has a comment which states that, I will make it clearer in the javadocs of nextDoc().
          Hide
          Michael Busch added a comment -

          Committed revision 720609.

          Show
          Michael Busch added a comment - Committed revision 720609.

            People

            • Assignee:
              Michael Busch
              Reporter:
              Michael Busch
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development