Lucene - Core
  1. Lucene - Core
  2. LUCENE-1443

Performance improvement in OpenBitSetDISI.inPlaceAnd()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9
    • Component/s: core/other, modules/other
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available
    1. LUCENE-1443b.patch
      5 kB
      Paul Elschot
    2. LUCENE-1443.patch
      1 kB
      Paul Elschot

      Activity

      Hide
      Paul Elschot added a comment -

      For those interested in OpenBitSet and DocIdSetIterator: just have a look at the patch,
      ant test-contrib
      passes.

      Show
      Paul Elschot added a comment - For those interested in OpenBitSet and DocIdSetIterator: just have a look at the patch, ant test-contrib passes.
      Hide
      Paul Elschot added a comment -

      Once more with licence grant.

      Show
      Paul Elschot added a comment - Once more with licence grant.
      Hide
      Paul Elschot added a comment -

      Some more bits, some less.
      The b patch should be faster than the previous one.

      Show
      Paul Elschot added a comment - Some more bits, some less. The b patch should be faster than the previous one.
      Hide
      Yonik Seeley added a comment -

      Looks good Paul, the int version of clear() makes sense in this context given how many times it can be called.
      I'll commit LUCENE-1443b.patch shortly unless you have more changes coming.

      Show
      Yonik Seeley added a comment - Looks good Paul, the int version of clear() makes sense in this context given how many times it can be called. I'll commit LUCENE-1443 b.patch shortly unless you have more changes coming.
      Hide
      Paul Elschot added a comment -

      Thanks for taking a look Yonik, I was about to invite you to do that.

      Maybe the duplication between the long and int version of clear() could be refactored into a private method, but I'm not going to bother further; my normal tolerance level for code duplication is at most 2 duplicates not too far from each other.

      Show
      Paul Elschot added a comment - Thanks for taking a look Yonik, I was about to invite you to do that. Maybe the duplication between the long and int version of clear() could be refactored into a private method, but I'm not going to bother further; my normal tolerance level for code duplication is at most 2 duplicates not too far from each other.
      Hide
      Yonik Seeley added a comment -

      Thanks Paul, I just committed this (and also set eol-style on OpenBitSet.java)

      Show
      Yonik Seeley added a comment - Thanks Paul, I just committed this (and also set eol-style on OpenBitSet.java)

        People

        • Assignee:
          Unassigned
          Reporter:
          Paul Elschot
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development