[LUCENE-1415] MultiPhraseQuery has incorrect hashCode() implementation - Leads to Solr Cache misses

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4
• Component/s: core/search
• Lucene Fields: New
• Assignee: Yonik Seeley
• Reporter: Todd Feak
• Created: 08/Oct/08 23:30
• Updated: 28/Aug/22 11:53
• Resolved: 10/Oct/08 19:46

Description

I found this while hunting for the cause of Solr Cache misses.

The MultiPhraseQuery class hashCode() implementation is non-deterministic. It uses termArrays.hashCode() in the computation. The contents of that ArrayList are actually arrays themselves, which return there reference ID as a hashCode instead of returning a hashCode which is based on the contents of the array. I would suggest an implementation involving the Arrays.hashCode() method.

I will try to submit a patch soon, off for today.

Issue Links

• is related to: SOLR-805 DisMax queries are not being cached in QueryResultCache