Lucene - Core
  1. Lucene - Core
  2. LUCENE-1415

MultiPhraseQuery has incorrect hashCode() implementation - Leads to Solr Cache misses

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: None
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I found this while hunting for the cause of Solr Cache misses.

      The MultiPhraseQuery class hashCode() implementation is non-deterministic. It uses termArrays.hashCode() in the computation. The contents of that ArrayList are actually arrays themselves, which return there reference ID as a hashCode instead of returning a hashCode which is based on the contents of the array. I would suggest an implementation involving the Arrays.hashCode() method.

      I will try to submit a patch soon, off for today.

      1. LUCENE-1415.patch
        3 kB
        Mark Miller
      2. LUCENE-1415.patch
        3 kB
        Mark Miller
      3. MultiPhraseQuery.java
        11 kB
        Todd Feak
      4. MultiPhraseQueryTest.java
        0.9 kB
        Todd Feak

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Yonik Seeley
              Reporter:
              Todd Feak
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development