Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1366

Rename Field.Index.UN_TOKENIZED/TOKENIZED/NO_NORMS

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2
    • Fix Version/s: 2.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      There is confusion about these current Field options and I think we
      should rename them, deprecating the old names in 2.4/2.9 and removing
      them in 3.0. How about this:

      TOKENIZED --> ANALYZED
      UN_TOKENIZED --> NOT_ANALYZED
      NO_NORMS --> NOT_ANALYZED_NO_NORMS
      

      Should we also add ANALYZED_NO_NORMS?

      Spinoff from here:

      http://mail-archives.apache.org/mod_mbox/lucene-java-user/200808.mbox/%3C48a3076a.2679420a.1c53.ffffa5c4%40mx.google.com%3E

      1. LUCENE-1366.patch
        226 kB
        Michael McCandless
      2. LUCENE-1366.patch
        4 kB
        Michael McCandless

        Issue Links

          Activity

          Hide
          mikemccand Michael McCandless added a comment -

          Initial patch attached.

          I intend also fix all places where we use the now-deprecated older names to use the new names on the next rev of this patch, but wanted to get the basic change out first in case anyone has violent reactions to the new proposed names Naming is always the hardest part!

          Show
          mikemccand Michael McCandless added a comment - Initial patch attached. I intend also fix all places where we use the now-deprecated older names to use the new names on the next rev of this patch, but wanted to get the basic change out first in case anyone has violent reactions to the new proposed names Naming is always the hardest part!
          Hide
          otis Otis Gospodnetic added a comment -

          I like the name choices - they read nicely, are easy to understand, and match what actually happens.

          Show
          otis Otis Gospodnetic added a comment - I like the name choices - they read nicely, are easy to understand, and match what actually happens.
          Hide
          mikemccand Michael McCandless added a comment -

          OK, this patch switches over all uses of the old names to the new ones.

          I plan to commit in a day or two.

          Show
          mikemccand Michael McCandless added a comment - OK, this patch switches over all uses of the old names to the new ones. I plan to commit in a day or two.
          Hide
          mikemccand Michael McCandless added a comment -

          Committed revision 694004.

          Show
          mikemccand Michael McCandless added a comment - Committed revision 694004.

            People

            • Assignee:
              mikemccand Michael McCandless
              Reporter:
              mikemccand Michael McCandless
            • Votes:
              2 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development