Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Would be nice to have programmatic access to the CheckIndex tool, so that it can be used in applications like Solr.

      See SOLR-566

      1. LUCENE-1354.patch
        20 kB
        Grant Ingersoll
      2. LUCENE-1354.patch
        18 kB
        Michael McCandless
      3. LUCENE-1354.patch
        18 kB
        Grant Ingersoll

        Issue Links

          Activity

          Hide
          gsingers Grant Ingersoll added a comment -

          Here's some incomplete doodling on this issue. Haven't had time to finish it off, but thought I'd get it out of my source tree for now and come back to it later.

          Show
          gsingers Grant Ingersoll added a comment - Here's some incomplete doodling on this issue. Haven't had time to finish it off, but thought I'd get it out of my source tree for now and come back to it later.
          Hide
          mikemccand Michael McCandless added a comment -

          Hi Grant, the patch looks good! I tweaked it a bit, to pass all tests, and also pulled out a separate fix() method as suggested here:

          http://mail-archives.apache.org/mod_mbox/lucene-java-dev/200809.mbox/%3C4d0b24970809061944n5c617b36xc2951d74d989dc42%40mail.gmail.com%3E

          If this looks good can you commit for 2.4?

          Show
          mikemccand Michael McCandless added a comment - Hi Grant, the patch looks good! I tweaked it a bit, to pass all tests, and also pulled out a separate fix() method as suggested here: http://mail-archives.apache.org/mod_mbox/lucene-java-dev/200809.mbox/%3C4d0b24970809061944n5c617b36xc2951d74d989dc42%40mail.gmail.com%3E If this looks good can you commit for 2.4?
          Hide
          gsingers Grant Ingersoll added a comment -
          Show
          gsingers Grant Ingersoll added a comment - will do. -------------------------- Grant Ingersoll http://www.lucidimagination.com Lucene Helpful Hints: http://wiki.apache.org/lucene-java/BasicsOfPerformance http://wiki.apache.org/lucene-java/LuceneFAQ
          Hide
          gsingers Grant Ingersoll added a comment - - edited

          Mike, I think you forgot to add the CheckIndexStatus class to your patch. However, I reproduced it from an old version here, plus your additions.

          Show
          gsingers Grant Ingersoll added a comment - - edited Mike, I think you forgot to add the CheckIndexStatus class to your patch. However, I reproduced it from an old version here, plus your additions.
          Hide
          gsingers Grant Ingersoll added a comment -

          Has CheckIndexStatus. Will commit shortly

          Show
          gsingers Grant Ingersoll added a comment - Has CheckIndexStatus. Will commit shortly
          Hide
          mikemccand Michael McCandless added a comment -

          Mike, I think you forgot to add the CheckIndexStatus class to your patch. However, I reproduced it from an old version here, plus your additions.

          Woops, sorry. We really need the "svn patch" command, so that it would have locally added that file on me applying the patch. Sigh. But you worked around this just fine

          Show
          mikemccand Michael McCandless added a comment - Mike, I think you forgot to add the CheckIndexStatus class to your patch. However, I reproduced it from an old version here, plus your additions. Woops, sorry. We really need the "svn patch" command, so that it would have locally added that file on me applying the patch. Sigh. But you worked around this just fine
          Hide
          mikemccand Michael McCandless added a comment -

          Grant, this is now fixed right?

          Show
          mikemccand Michael McCandless added a comment - Grant, this is now fixed right?

            People

            • Assignee:
              gsingers Grant Ingersoll
              Reporter:
              gsingers Grant Ingersoll
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development