[LUCENE-1326] Inflater.end() method not always called in FieldsReader

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.1
• Fix Version/s: 2.4
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Robert Newson
• Created: 03/Jul/08 17:32
• Updated: 28/Aug/22 11:51
• Resolved: 04/Jul/08 09:20

Description

We've just found an insidious memory leak in our own application as we did not always call Deflater.end() and Inflater.end(). As documented here;

http://bugs.sun.com/view_bug.do?bug_id=4797189

The non-heap memory that the native zlib code uses is not freed in a timely manner.

FieldsWriter appears safe as no exception can be thrown between the Deflater's creation and end() as it uses a ByteArrayOutputStream

FieldsReader, however, is not safe. In the event of a DataFormatException the call to end() will not occur.