Lucene - Core
  1. Lucene - Core
  2. LUCENE-1295

Make retrieveTerms(int docNum) public in MoreLikeThis

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: modules/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      It would be useful if

      private PriorityQueue retrieveTerms(int docNum) throws IOException {
      

      were public, since it is similar in use to

      public PriorityQueue retrieveTerms(Reader r) throws IOException {
      

      It also seems useful to add

      public String [] retrieveInterestingTerms(int docNum) throws IOException{
      

      to mirror the one that works on Reader.

      1. LUCENE-1295.patch
        2 kB
        Grant Ingersoll

        Activity

        Hide
        Grant Ingersoll added a comment -

        I'll commit in a day or two.

        Show
        Grant Ingersoll added a comment - I'll commit in a day or two.
        Hide
        Otis Gospodnetic added a comment -

        Perque no. I see MLT is full of tabs, should you feel like fixing the formating.

        Show
        Otis Gospodnetic added a comment - Perque no. I see MLT is full of tabs, should you feel like fixing the formating.
        Hide
        Grant Ingersoll added a comment -

        Perque no.

        Huh?

        I see MLT is full of tabs, should you feel like fixing the formating.

        Yeah, I noticed that too, and it is quite egregious, but I thought we avoided formatting changes, but I am happy to make an exception here.

        Show
        Grant Ingersoll added a comment - Perque no. Huh? I see MLT is full of tabs, should you feel like fixing the formating. Yeah, I noticed that too, and it is quite egregious, but I thought we avoided formatting changes, but I am happy to make an exception here.
        Hide
        Otis Gospodnetic added a comment -

        I think cosmetic changes are OK if:

        • they are not mixed with functional changes
        • there are no patches for the cleaned-up class(es) in JIRA

        In this case I see only a couple of MLT issues, all of which look like we can take care of them quickly, and then somebody can clean up a little if we feel like it. Anyhow...

        Show
        Otis Gospodnetic added a comment - I think cosmetic changes are OK if: they are not mixed with functional changes there are no patches for the cleaned-up class(es) in JIRA In this case I see only a couple of MLT issues, all of which look like we can take care of them quickly, and then somebody can clean up a little if we feel like it. Anyhow...
        Hide
        Grant Ingersoll added a comment -

        Committed revision 662413.

        Show
        Grant Ingersoll added a comment - Committed revision 662413.

          People

          • Assignee:
            Grant Ingersoll
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development