[LUCENE-1257] Port to Java5

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0
• Fix Version/s: 3.0
• Component/s: core/index, core/other, core/query/scoring, core/queryparser, core/search, core/store, core/termvectors, modules/analysis, modules/examples
• Lucene Fields: New, Patch Available
• Assignee: Uwe Schindler
• Reporter: Cédric Champeau
• Created: 02/Apr/08 08:29
• Updated: 28/Aug/22 11:49
• Resolved: 13/Nov/09 11:39

Description

For my needs I've updated Lucene so that it uses Java 5 constructs. I know Java 5 migration had been planned for 2.1 someday in the past, but don't know when it is planned now. This patch against the trunk includes :

• most obvious generics usage (there are tons of usages of sets, ... Those which are commonly used have been generified)
• PriorityQueue generification
• replacement of indexed for loops with for each constructs
• removal of unnececessary unboxing

The code is to my opinion much more readable with those features (you actually know what is stored in collections reading the code, without the need to lookup for field definitions everytime) and it simplifies many algorithms.

Note that this patch also includes an interface for the Query class. This has been done for my company's needs for building custom Query classes which add some behaviour to the base Lucene queries. It prevents multiple unnnecessary casts. I know this introduction is not wanted by the team, but it really makes our developments easier to maintain. If you don't want to use this, replace all /Queriable/ calls with standard /Query/.

Issue Links

• incorporates: LUCENE-1984 DisjunctionMaxQuery - Type safety
• incorporates: LUCENE-1833 When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
• relates to: LUCENE-1933 Provide an convenience AttributeFactory that implements all default attributes with Token
• relates to: LUCENE-1855 Change AttributeSource API to use generics
• relates to: LUCENE-1857 Change NumericRangeQuery to generics (for the numeric type)
• relates to: LUCENE-1998 Use Java 5 enums
• relates to: LUCENE-1935 Generify PriorityQueue
• relates to: LUCENE-2000 Use covariant clone() return types