[LUCENE-1254] addIndexesNoOptimize should not enforce maxMergeDocs/maxMergeSize limit

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.1, 2.2, 2.3
• Fix Version/s: 2.3.2, 2.4
• Component/s: core/index
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Michael McCandless
• Created: 31/Mar/08 09:21
• Updated: 28/Aug/22 11:48
• Resolved: 01/Apr/08 06:59

Description

If you pass an index that has a segment > maxMergeDocs or maxMergeSize
to addIndexesNoOptimize, it throws an IllegalArgumentException.

But this check isn't reasonable because segment merging can easily
produce segments over these sizes since those limits apply to each
segment being merged, not to the final size of the segment produced.

So if you set maxMergeDocs to X, build up and index, then try to add
that index to another index that also has maxMergeDocs X, you can
easily hit the exception.

I think it's being too pedantic; I plan to just remove the checks for
sizes.