Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1251

on disk full during close, FSIndexOutput fails to close descriptor

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1
    • Fix Version/s: 2.3.2, 2.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The close method just does this:

            if (isOpen) {
              super.close();
              file.close();
              isOpen = false;
            }
      

      But super.close = BufferedIndexOutput.close, which tries to flush its buffer. If disk is full (or something else is wrong) then we hit an exception and don't actually close the descriptor.

      I will put a try/finally in so we always close, taking care to preserve the original exception. I'll commit shortly & backport to 2.3.2

        Attachments

          Activity

            People

            • Assignee:
              mikemccand Michael McCandless
              Reporter:
              mikemccand Michael McCandless
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: