[LUCENE-1248] Unncessary creation of object in org.apache.lucene.analysis.WordlistLoader.getWordSet()

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Won't Fix
• Affects Version/s: 2.3.1, 2.3.2
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: David Dillard
• Created: 27/Mar/08 19:40
• Updated: 28/Aug/22 11:48
• Resolved: 10/Mar/13 13:31

Description

Here's the function:

public static HashSet getWordSet(File wordfile) throws IOException {
HashSet result = new HashSet();
FileReader reader = null;
try

{ reader = new FileReader(wordfile); result = getWordSet(reader); }

finally

{ if (reader != null) reader.close(); }

return result;
}

The creation of the new HashSet object in the declaration of "result" is unnecessary. Either "result" will be unconditionally set by the call to getWordSet() or an exception will occur.

This was detected by FindBugs.