Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1210

IndexWriter & ConcurrentMergeScheduler deadlock case if starting a merge hits an exception

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.3.1
    • Fix Version/s: 2.3.2, 2.4
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      If you're using CMS (the default) and mergeInit hits an exception (eg
      OOME), we are not properly clearing IndexWriter's internal tracking of
      running merges. This causes IW.close() to hang while it incorrectly
      waits for these non-started merges to finish.

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        The fix is trivial: add a try/finally to mergeInit to clear the
        internal tracking on exception. I'll commit shortly.

        Show
        mikemccand Michael McCandless added a comment - The fix is trivial: add a try/finally to mergeInit to clear the internal tracking on exception. I'll commit shortly.
        Hide
        michele Michele Bini added a comment -

        Uhm, shouldn't the patch be committed in the 2.3 branch, too, as it affects 2.3.1?

        Show
        michele Michele Bini added a comment - Uhm, shouldn't the patch be committed in the 2.3 branch, too, as it affects 2.3.1?
        Hide
        mikemccand Michael McCandless added a comment -

        Yes, I agree. At some point soon we should do a 2.3.2 point release, and I'll port this issue back for that.

        Show
        mikemccand Michael McCandless added a comment - Yes, I agree. At some point soon we should do a 2.3.2 point release, and I'll port this issue back for that.
        Hide
        hossman Hoss Man added a comment -

        targeted for 2.3.2 bug fix release

        Show
        hossman Hoss Man added a comment - targeted for 2.3.2 bug fix release

          People

          • Assignee:
            mikemccand Michael McCandless
            Reporter:
            mikemccand Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development