Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1186

[PATCH] Clear ThreadLocal instances in close()

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3, 2.3.1, 2.4
    • 2.4.1, 2.9
    • None
    • None
    • any

    • New, Patch Available

    Description

      As already found out in LUCENE-436, there seems to be a garbage collection problem with ThreadLocals at certain constellations, resulting in an OutOfMemoryError.
      The resolution there was to remove the reference to the ThreadLocal value when calling the close() method of the affected classes (see FieldsReader and TermInfosReader).
      For Java < 5.0, this can effectively be done by calling threadLocal.set(null); for Java >= 5.0, we would call threadLocal.remove()

      Analogously, this should be done in any class which creates ThreadLocal values

      Right now, two classes of the core API make use of ThreadLocals, but do not properly remove their references to the ThreadLocal value
      1. org.apache.lucene.index.SegmentReader
      2. org.apache.lucene.analysis.Analyzer

      For SegmentReader, I have attached a simple patch.
      For Analyzer, there currently is no patch because Analyzer does not provide a close() method (future to-do?)

      Attachments

        1. LUCENE-1186-SegmentReader.patch
          0.3 kB
          Christian Kohlschütter
        2. LUCENE-1186.patch
          3 kB
          Michael McCandless
        3. LUCENE-1186.patch
          3 kB
          Michael McCandless

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mikemccand Michael McCandless
            ck@newsclub.de Christian Kohlschütter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment