Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1079

DocValues cleanup: constructor & getInnerArray()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3
    • 2.3
    • core/search
    • None
    • Patch Available

    Description

      DocValues constructor taking a numDocs parameter is not very clean.
      Get rid of this.

      Also, it's optional getInnerArray() method is not very clean.
      This is necessary for better testing, but currently tests will fail if it is not implemented.
      Modify it to throw UnSupportedOp exception (rather than returning an empty array).
      Modify tests to not fail but just warn if the tested iml does not override it.

      These changes should make it easier to implement DocValues for other ValueSource's, e.g. above payloads, with or without caching.

      Attachments

        Activity

          People

            doronc Doron Cohen
            doronc Doron Cohen
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: