Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1071

SegmentMerger doesn't set payload bit in new optimized code

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In the new optimized code in SegmentMerger the payload bit is not set correctly
      in the merged segment. This means that we loose all payloads during a merge!

      The Payloads unit test doesn't catch this. Now that we have the new
      DocumentsWriter we buffer much more docs by default then before. This means
      that the test cases can't assume anymore that the DocsWriter flushes after 10
      docs by default. TestPayloads however falsely assumed this, which means that no
      merges happen anymore in TestPayloads. We should check whether there are
      other testcases that rely on this.

      The fixes for TestPayloads and SegmentMerger are very simple, I'll attach a patch
      soon.

      1. lucene-1071.patch
        2 kB
        Michael Busch

        Activity

        Hide
        michaelbusch Michael Busch added a comment -

        I'm going to commit this very soon.

        Show
        michaelbusch Michael Busch added a comment - I'm going to commit this very soon.
        Hide
        michaelbusch Michael Busch added a comment -

        Committed.

        Show
        michaelbusch Michael Busch added a comment - Committed.

          People

          • Assignee:
            michaelbusch Michael Busch
            Reporter:
            michaelbusch Michael Busch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development