Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1064

Make TopDocs constructor public

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.2
        • Fix Version/s: None
        • Component/s: core/search
        • Labels:
          None
        • Environment:

          All

        • Lucene Fields:
          New

          Description

          TopDocs constructor is package visible. This prevents instantiating it from outside this package. For example, I wrote a HitColletor that couldn't extend directly from TopDocCollector. I need to create a new TopDocs instance, however since the c'tor is package visible, I can't do that.
          For now, I completely duplicated the code, but I hope you'll fix it soon.

          1. HTML File
            TopDocs-patch
            0.6 kB
            Shai Erera

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            shaie Shai Erera added a comment -

            The simple patch details

            Show
            shaie Shai Erera added a comment - The simple patch details
            Hide
            Permalink
            michaelbusch Michael Busch added a comment -

            Committed. Thanks, Shai!

            Show
            michaelbusch Michael Busch added a comment - Committed. Thanks, Shai!

              People

              • Assignee:
                michaelbusch Michael Busch
                Reporter:
                shaie Shai Erera
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development