Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-10433

we should pass l instead of d to getFallbackSelector(d).select in RadixSelector.select()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Resolved
    • 8.6.2
    • None
    • core/other
    • None
    • New

    Description

      In the `RadixSelector.select`

        private void select(int from, int to, int k, int d, int l) {
          if (to - from <= LENGTH_THRESHOLD || d >= LEVEL_THRESHOLD) { 
            getFallbackSelector(d).select(from, to, k); 
          } else {
            radixSelect(from, to, k, d, l); 
          }
        }
      

      we know that `l` represent the levels of recursion, not the `d`, but when we check the levels of recursion, we use `d >= LEVEL_THRESHOLD`, it's not right.

      Attachments

        Activity

          People

            Unassigned Unassigned
            kkewwei kkewwei
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: