Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-10373

Can we optimize TaxonomyFacetSumIntAssociations#sumValues?

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • modules/facet
    • None
    • New

    Description

      It looks like TaxonomyFacetSumIntAssociations#sumValues might also benefit from reduced null checks just like in LUCENE-10350 (doing away with the use of the parent class increment method).

      While we're at it, it would be nice to test moving to little endian encoding of the ord/value since we're trying to deprecate BitUtil.VH_BE_INT.

      The real challenge is that we don't have benchmark tasks for this class. Maybe we should add benchmarking first? I opened a luceneutil issue for this: https://github.com/mikemccand/luceneutil/issues/158

      Attachments

        1. LUCENE-10373.patch
          3 kB
          Greg Miller

        Activity

          People

            Unassigned Unassigned
            gsmiller Greg Miller
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: