[LUCENE-10244] Please consider opening MultiCollector::getCollectors for public use

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.10.1
• Fix Version/s: 9.1, 10.0 (main)
• Component/s: core/search
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Andriy Redko
• Created: 18/Nov/21 19:35
• Updated: 28/Aug/22 16:30
• Resolved: 21/Nov/21 15:55

Description

The usage of MultiCollector sometimes is very convenient along with CollectorManagers instances (as an alternative to MultiCollectorManager), for example:

class SomeCollectorManager implements CollectorManager<Collector, ?> {
    @Override
    public Collector newCollector() throws IOException {
      return MultiCollector.wrap(new Collector1(), new Collector2(), ...);
    }
    @Override
    public List<Integer> reduce(Collection<Collector> collectors) throws IOException {
      return ...;
    }
}

Unfortunately, the reduce() phase is lacking the access to  MultiCollector::getCollectors method, since it is package protected at the moment. Making MultiCollector::getCollectors  public would make it convenient to use MultiCollector + CollectorManager and implement the reduce phase by accessing individual collectors.

Issue Links

• links to: GitHub Pull Request #455