[LUCENE-10070] "count all" faceting functionality counts deleted docs for multiple implementations

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0, 8.11
• Component/s: modules/facet
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Greg Miller
• Created: 26/Aug/21 00:40
• Updated: 28/Aug/22 16:25
• Resolved: 27/Sep/21 19:16

Description

A few different Facets implementations supporting a "count all" style constructor that allows the user to not pass in a FacetsCollector instance. It advertises that it's equivalent to using a FacetsCollector populated with a MatchAllDocsQuery, but more efficient. It looks like, with the exception of FastTaxonomyFacetCounts, none of the implementations correctly account for deleted documents (have a look at FastTaxonomyFacetCounts for a correct example that consults "live docs."

From what I can tell, the affected implementations are:

• SortedSetDocValueFacetCounts
• ConcurrentSortedSetDocValueFacetCounts
• LongValueFacetCounts
• StringValueFacetCounts

I'll attach a PR shortly illustrating unit tests I wrote that confirm the bug.

Issue Links

• links to: GitHub Pull Request #263
• links to: GitHub Pull Request #323
• links to: GitHub Pull Request #2577
• links to: GitHub Pull Request #2584