Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-10060

Ensure DrillSidewaysQuery instances don't get cached

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 9.0, 8.10
    • modules/facet
    • None
    • New

    Description

      We need to make sure DSQ instances don't end up in the query cache. It's important that the DrillSidewaysScorer (bulk scorer implementation) actually runs during query evaluation in order to populate the "sideways" FacetsCollector instances with "near miss" docs. If it gets cached, this won't happen.

      There may also be an implication around acceptDocs getting honored as well. zacharymorn may be able to provide more details.

      UPDATE: The original issue I detailed above isn't actually an issue since DrillDownQuery doesn't implement equals, so the cache always misses and it always executes the BulkScorer ( DrillSidewaysScorer ). Tricky! There is a separate issue found by Zach (as mentioned above) related to "acceptDocs" though. See below conversation and link off to the separate PR conversation for more details.

      Attachments

        Activity

          People

            Unassigned Unassigned
            gsmiller Greg Miller
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m