[LUCENE-10036] Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 9.0, 8.10
• Fix Version/s: 9.0, 8.10
• Component/s: core/search
• Lucene Fields: New, Patch Available
• Assignee: Greg Miller
• Reporter: Greg Miller
• Created: 26/Jul/21 20:36
• Updated: 28/Aug/22 16:24
• Resolved: 27/Jul/21 18:08

Description

This is a trivial issue, but it's easy to mistakenly "double wrap" an instance of ScoreCachingWrappingScorer, which is a bit wasteful. The calling code currently needs to check the instance type of the Scorable they intend to wrap to avoid this. FieldComparator is actually the only calling code that does this check.

It would be nice to add a factory method that encapsulates this check in ScoreCachingWrappingScorer so that calling code doesn't need to worry about it.

 

Issue Links

• links to: GitHub Pull Request #226
• links to: GitHub Pull Request #2534