[LOGGING-25] [logging] call to getClassLoader() in LogFactoryImpl not checked for null

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.4
• Fix Version/s: 1.1.0

Environment

Operating System: other
Platform: Other

• Bugzilla Id: 37484
• Assignee: Unassigned
• Reporter: Luke Sleeman
• Created: 14/Nov/05 13:59
• Updated: 29/Dec/09 14:28
• Resolved: 19/Dec/06 21:12

Description

In line 374 of LogFactoryImpl.java getClassLoader() is called:

logInterface = this.getClass().getClassLoader().loadClass(LOG_INTERFACE);

However, the docs for getClassLoader() state that some implementations may use
null to return the system classloader. This occurs under CrEme a JVM for the
PocketPC platform which some of our products run under, causing a null pointer
exception. Perhaps it would be better to change line 374 to read:

logClass = loadClass(LOG_INTERFACE);

which seems to solve the problems I have been having. At any rate calls to
getClassLoader() should be checked to ensure that they haven't returned null.

In addition the error that I got:
org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException:
java.lang.NullPointerException (Caused by java.lang.NullPointerException)
(Caused by org.apache.commons.logging.LogConfigurationException:
java.lang.NullPointerException (Caused by java.lang.NullPointerException))

Certianly wasnt very helpfull for figuring out what is going on.

• Luke