Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.2
    • Fix Version/s: 1.1.3
    • Labels:
      None

      Description

      Version 1.1.2 got a Manifest.mf that supports OSGi. Unfortunately, the bundle id specified there is incorrect. According to http://wiki.osgi.org/wiki/Bundle-SymbolicName "A BSN often takes the form of a reverse domain name. " So the proper and expected name would be org.apache.commons.logging .

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          6d 12h 16m 1 Thomas Neidhart 15/Apr/13 19:48
          Resolved Resolved Closed Closed
          34d 22h 34m 1 Thomas Neidhart 20/May/13 18:22
          Thomas Neidhart made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Thomas Neidhart made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 1.1.3 [ 12324321 ]
          Resolution Fixed [ 1 ]
          Hide
          Thomas Neidhart added a comment -

          BSN changed to "org.apache.commons.logging" in r1468180.

          Show
          Thomas Neidhart added a comment - BSN changed to "org.apache.commons.logging" in r1468180.
          Hide
          Gary Gregory added a comment -

          I like following in [lang] and [collections]'s footsteps and a more conventional BSN.

          Show
          Gary Gregory added a comment - I like following in [lang] and [collections] 's footsteps and a more conventional BSN.
          Hide
          Thomas Neidhart added a comment -

          If everybody agrees that this is the right thing to do we can also do a quick 1.1.3 release which contains only this change.

          Show
          Thomas Neidhart added a comment - If everybody agrees that this is the right thing to do we can also do a quick 1.1.3 release which contains only this change.
          Joerg Schaible made changes -
          Link This issue relates to LOGGING-124 [ LOGGING-124 ]
          Hide
          Emmanuel Bourg added a comment -

          If the next release has a new groupId that means it will be binary incompatible and live in a different package. That leaves the 1.1.x line with broken OSGi metadata forever.

          Show
          Emmanuel Bourg added a comment - If the next release has a new groupId that means it will be binary incompatible and live in a different package. That leaves the 1.1.x line with broken OSGi metadata forever.
          Emmanuel Bourg made changes -
          Summary Invalid bundle id Invalid OSGi bundle id
          Hide
          Thomas Neidhart added a comment - - edited

          The next release will update the groupId to org.apache.commons and we will also update the symbolic name accordingly.

          Edit: prior to the 1.1.2 release the symbolic name was already changed to org.apache.commons.logging, but was reverted to commons-logging based on a patch from an Apache Felix committer (see LOGGING-124).

          Show
          Thomas Neidhart added a comment - - edited The next release will update the groupId to org.apache.commons and we will also update the symbolic name accordingly. Edit: prior to the 1.1.2 release the symbolic name was already changed to org.apache.commons.logging, but was reverted to commons-logging based on a patch from an Apache Felix committer (see LOGGING-124 ).
          Hide
          Emmanuel Bourg added a comment -

          For the record, Commons Collection which is still in the old commons-collections groupId has been OSGified with:

          Bundle-SymbolicName: org.apache.commons.collections

          Same thing with Commons Lang.

          Show
          Emmanuel Bourg added a comment - For the record, Commons Collection which is still in the old commons-collections groupId has been OSGified with: Bundle-SymbolicName: org.apache.commons.collections Same thing with Commons Lang.
          Hide
          Krzysztof Daniel added a comment -

          Yes, I'm aware of that. I'd question the existing groupId/artifactId, too, if only had not it been used for such a long time in its current form.
          The same wiki page provides an example which is in the form of a reverse domain name notation. Also, commons-logging is a widely distributed as an OSGI bundle in Eclipse, which wraps it as org.apache.commons.logging (according to http://wiki.eclipse.org/index.php/Naming_Conventions).

          Maven conventions (https://maven.apache.org/guides/mini/guide-naming-conventions.html) suggest groupId on a project level (org.apache.commons is listed as an example), so a natural consequence would be naming a jar logging.jar and getting $

          {pom.groupId}

          .$

          {pom.artifactId}

          resolved to org.apache.commons.logging.

          This is of course a very drastic change to the whole community, and I don't want to insist on it (although it would be nice).

          I'm, however, using this package in Fedora, and it has been osgified there, and in Eclipse, for a long time, with org.apache.commons.logging id. Current name (commons-logging) is a breaker for me, and I'll have to patch it otherwise.

          Show
          Krzysztof Daniel added a comment - Yes, I'm aware of that. I'd question the existing groupId/artifactId, too, if only had not it been used for such a long time in its current form. The same wiki page provides an example which is in the form of a reverse domain name notation. Also, commons-logging is a widely distributed as an OSGI bundle in Eclipse, which wraps it as org.apache.commons.logging (according to http://wiki.eclipse.org/index.php/Naming_Conventions ). Maven conventions ( https://maven.apache.org/guides/mini/guide-naming-conventions.html ) suggest groupId on a project level (org.apache.commons is listed as an example), so a natural consequence would be naming a jar logging.jar and getting $ {pom.groupId} .$ {pom.artifactId} resolved to org.apache.commons.logging. This is of course a very drastic change to the whole community, and I don't want to insist on it (although it would be nice). I'm, however, using this package in Fedora, and it has been osgified there, and in Eclipse, for a long time, with org.apache.commons.logging id. Current name (commons-logging) is a breaker for me, and I'll have to patch it otherwise.
          Hide
          Thomas Neidhart added a comment -

          The same page also states:

          If automatically generated via Maven Bundle Plugin, takes the form ${pom.groupId}.${pom.artifactId}, or ${pom.artifactId} if it already starts with ${pom.groupId}. 
          

          and this is what has been used as the groupId/artifactId is still commons-logging.

          Show
          Thomas Neidhart added a comment - The same page also states: If automatically generated via Maven Bundle Plugin, takes the form ${pom.groupId}.${pom.artifactId}, or ${pom.artifactId} if it already starts with ${pom.groupId}. and this is what has been used as the groupId/artifactId is still commons-logging.
          Krzysztof Daniel made changes -
          Field Original Value New Value
          Affects Version/s 1.1.2 [ 12314498 ]
          Affects Version/s 1.1.1 [ 12312160 ]
          Krzysztof Daniel created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Krzysztof Daniel
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development