Commons Logging
  1. Commons Logging
  2. LOGGING-128

Static analysis suggests a number of potential improvements

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.2
    • Labels:
      None

      Description

      Improvements include;

      • final fields where possible
      • static methods where possible.
      • simplifying code to improve clarity.

        Activity

        Hide
        Sebb added a comment -

        Thanks, applied, apart from a few places where strings were being changed to characters. Also did not replace StringBuffer manipulation with String concatenation where not all input was fixed strings.

        URL: http://svn.apache.org/viewvc?rev=1363030&view=rev
        Log:
        LOGGING-128 - Static analysis suggests a number of potential improvements

        Modified:
        commons/proper/logging/trunk/RELEASE-NOTES.txt
        commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
        commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java
        commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java
        commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
        commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/ServletContextCleaner.java
        commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/WeakHashtable.java

        Show
        Sebb added a comment - Thanks, applied, apart from a few places where strings were being changed to characters. Also did not replace StringBuffer manipulation with String concatenation where not all input was fixed strings. URL: http://svn.apache.org/viewvc?rev=1363030&view=rev Log: LOGGING-128 - Static analysis suggests a number of potential improvements Modified: commons/proper/logging/trunk/RELEASE-NOTES.txt commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/ServletContextCleaner.java commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/WeakHashtable.java

          People

          • Assignee:
            Unassigned
            Reporter:
            Peter Lawrey
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development