[LOGCXX-558] Prevent MSVC compilation warnings "needs to have dll-interface"

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Assignee: Unassigned
• Reporter: Stephen Webb
• Created: 16/Aug/22 02:21
• Updated: 24/Sep/22 13:15
• Resolved: 24/Sep/22 13:15

Description

The private data of classes do not prevent Microsoft compiler warning messages.

 

As the private data is inaccessible by client application it should be safe to ignore the warning. This can be done using a macro 

```

#if _WIN32
#define LOG4CXX_DECLARE_PRIVATE_MEMBER_PTR(T, V) \
__pragma( warning( push ) ) \
__pragma( warning( disable : 4251 ) ) \
    struct T; std::unique_ptr<T> V; \
__pragma( warning( pop ) )

#else

#define LOG4CXX_DECLARE_PRIVATE_MEMBER_PTR(T, V) struct T; std::unique_ptr<T> V;
#endif /* WIN32 */

```