Log4cxx
  1. Log4cxx
  2. LOGCXX-262

SocketAppenderTestCase and XMLSocketAppenderTestCase never run

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: Tests
    • Labels:
      None

      Description

      On Apr 2, 2008, at 5:04 PM, Curt Arnold wrote:

      On Mar 31, 2008, at 4:32 PM, Bernard Stumpf wrote:
      I've searched for evidence that any of the SocketAppender test cases were run by the log4cxx tests, and it appears that these tests are not run. The only related one is "sockethubappendertestcase: SUCCESS", but that is not a client logger case, I think.

      Looking through the log4cxx issues:
      LOGCXX-164: XMLSocketAppender is disabled - is marked fixed.
      LOGCXX-165 XMLSocketAppender may generate erroneous output - also marked fixed.

      Please explain. Should there be a SocketAppender test case run as part of the log4cxx tests?

      -Bernie Stumpf

      Sorry not to get back to you. The test you mention are not run since they are guarded by an APR_HAS_THREADS, but no APR header files is included that could potentially set that macro. If you add an

      #include "apr.h"

      before the

      #if defined(APR_HAS_THREADS)

      then the test should run (though they don't do much) on every common platform except Cygwin. I considered, but decided against, trying to fix that in RC8.

        Activity

        Hide
        Curt Arnold added a comment -

        Fixed rev 651354

        Show
        Curt Arnold added a comment - Fixed rev 651354

          People

          • Assignee:
            Curt Arnold
            Reporter:
            Curt Arnold
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development