[LOGCXX-152] gcc warning about cast from `const void*' to `log4cxx::helpers::Object*' discards qualifiers from pointer target typ

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.10.0
• Environment: OS: linux; gcc: 3.4.4
• Assignee: Curt Arnold
• Reporter: hunger
• Created: 31/Aug/06 12:31
• Updated: 23/Oct/06 21:11
• Resolved: 23/Oct/06 21:11

Description

In the template "template<typename T> class ObjectPtrT" in file "include/log4cxx/helpers/objectptr.h"
the function "template<typename InterfacePtr> void cast(const InterfacePtr& p1)" uses an "unsafe" cast to (T*).
This triggers a gcc warning because the "const" qualifier gets casted away.

I tried the following:

template<typename InterfacePtr> void cast(const InterfacePtr& p1)
{

• T* newPtr = 0;
  + const T* newPtr = 0;
  if (p1 != 0) { - newPtr = (T*)p1->cast(T::getStaticClass()); + newPtr = (const T*)p1->cast(T::getStaticClass()); }

  operator=(newPtr);
  }

This compiles but the unittests fail.

In a comment to issue LOGCXX-14 another solution is provided:
https://issues.apache.org/jira/browse/LOGCXX-14#action_12315059