Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: Appender
    • Labels:
      None
    • Environment:
      Windows Visual Studio 2003

      Description

      I noticed the ODBC appender wasn't working and I needed it so I fixed the bugs with it.

      The attached patch file for build.xml also includes a property called "use-odbc" that will define LOG4CXX_HAVE_ODBC so that odbc support will be compiled in.

      The other files are patches to the source. I didn't try to to change the design, just to mkae the thing work.

      1. build.xml.patch
        1 kB
        Josh Clark
      2. class.cpp.patch
        0.5 kB
        Josh Clark
      3. odbcappender.cpp.patch
        9 kB
        Josh Clark
      4. odbcappender.h.patch
        4 kB
        Josh Clark

        Activity

        Hide
        Curt Arnold added a comment -

        Thanks for the patch. Sorry about the delay. Instead of tweaking build.xml, I modified include/log4cxx/log4cxx.hw (the template for the Windows configuration) to define LOG4CXX_HAVE_ODBC.

        The declaration of ODBCAppender is less than ideal since it exposes SQL-specific types and configuration details (specifically whether an ODBC library was found) in the header file and has no associated tests. I'd like to be able to drop ODBCAppender in favor of an APR DB based appender (see LOGCXX-61), but better to have a working ODBCAppender than a totally broken one even if it would be eventually dropped.

        Show
        Curt Arnold added a comment - Thanks for the patch. Sorry about the delay. Instead of tweaking build.xml, I modified include/log4cxx/log4cxx.hw (the template for the Windows configuration) to define LOG4CXX_HAVE_ODBC. The declaration of ODBCAppender is less than ideal since it exposes SQL-specific types and configuration details (specifically whether an ODBC library was found) in the header file and has no associated tests. I'd like to be able to drop ODBCAppender in favor of an APR DB based appender (see LOGCXX-61 ), but better to have a working ODBCAppender than a totally broken one even if it would be eventually dropped.

          People

          • Assignee:
            Curt Arnold
            Reporter:
            Josh Clark
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development