Log4php
  1. Log4php
  2. LOG4PHP-96

Some of the tests don't pass under Windows

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.1.0
    • Component/s: Code, Tests
    • Labels:
      None
    • Environment:

      Windows

      Description

      Some of the tests don't pass under Windows, due to unix specific functions (e.g. posix_*) and line endings (\n vs. PHP_EOL). Patch is attached.

      1. log4php-windows.patch
        18 kB
        Tommy Montgomery

        Activity

        Ivan Habunek made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Christian Grobmeier made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Christian Grobmeier added a comment -

        committed with rv904392. Thanks for the patch!

        Show
        Christian Grobmeier added a comment - committed with rv904392. Thanks for the patch!
        Christian Grobmeier made changes -
        Fix Version/s 2.1 [ 12313917 ]
        Fix Version/s 2.0 [ 12313916 ]
        Tommy Montgomery made changes -
        Affects Version/s 2.0 [ 12313916 ]
        Affects Version/s 2.1 [ 12313917 ]
        Fix Version/s 2.0 [ 12313916 ]
        Fix Version/s 2.1 [ 12313917 ]
        Hide
        Tommy Montgomery added a comment -

        fixed version number

        Show
        Tommy Montgomery added a comment - fixed version number
        Tommy Montgomery made changes -
        Field Original Value New Value
        Attachment log4php-windows.patch [ 12431658 ]
        Hide
        Tommy Montgomery added a comment -

        patch for windows tests and supporting source files.

        Show
        Tommy Montgomery added a comment - patch for windows tests and supporting source files.
        Tommy Montgomery created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Tommy Montgomery
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development