Uploaded image for project: 'Log4php'
  1. Log4php
  2. LOG4PHP-79

AppenderPDO: Some database fields seem a bit too short

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Code
    • Labels:
      None

      Description

      The default CREATAE TABLE statement in LoggerAppenderPDO is:

      $query = "CREATE TABLE {$this->table} ( timestamp varchar(32)," .
      "logger varchar(32)," .
      "level varchar(32)," .
      "message varchar(64)," .
      "thread varchar(32)," .
      "file varchar(64)," .
      "line varchar(4) );";

      It seems to me that 64 chars for the filename and message are a bit short.
      Even our examples are so deeply nested that the .php from the file name got cut off.
      I won't even think of a typical log message.

      I would propose to go for varchar(255) or even text ("clob") for message, varchar(255) for file and "int unsigned" for line (currently it looks like "9999 lines show be enough for everyone!"

        Attachments

          Activity

            People

            • Assignee:
              lathspell Christian Brunotte
              Reporter:
              lathspell Christian Brunotte
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: