Log4php
  1. Log4php
  2. LOG4PHP-79

AppenderPDO: Some database fields seem a bit too short

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Code
    • Labels:
      None

      Description

      The default CREATAE TABLE statement in LoggerAppenderPDO is:

      $query = "CREATE TABLE {$this->table} ( timestamp varchar(32)," .
      "logger varchar(32)," .
      "level varchar(32)," .
      "message varchar(64)," .
      "thread varchar(32)," .
      "file varchar(64)," .
      "line varchar(4) );";

      It seems to me that 64 chars for the filename and message are a bit short.
      Even our examples are so deeply nested that the .php from the file name got cut off.
      I won't even think of a typical log message.

      I would propose to go for varchar(255) or even text ("clob") for message, varchar(255) for file and "int unsigned" for line (currently it looks like "9999 lines show be enough for everyone!"

        Activity

        Christian Brunotte created issue -
        Christian Brunotte made changes -
        Field Original Value New Value
        Fix Version/s 2.0 [ 12313916 ]
        Christian Brunotte made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Christian Hammers [ lathspell ]
        Resolution Fixed [ 1 ]
        Ivan Habunek made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Christian Brunotte
            Reporter:
            Christian Brunotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development