Uploaded image for project: 'Log4php'
  1. Log4php
  2. LOG4PHP-56

Replace define('LOG4PHP_CONFIGURATION' by static variable

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.2.0
    • 2.0.0
    • Code
    • None

    Description

      As you're currently switching to PHP5 OOP code, I would suggest to replace this ugly global constant by a static attribute of the LogManager class i.e. LogManager::$configFile = ... Or maybe even a constructor/factory argument
      This would have the additional benefit that it could be set by some kind of Dependency Injection framework like Spring for Java, although I don't know of such is even existing for PHP But it might come in the future.

      Attachments

        Activity

          People

            Unassigned Unassigned
            lathspell Christian Brunotte
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: