Log4php
  1. Log4php
  2. LOG4PHP-56

Replace define('LOG4PHP_CONFIGURATION' by static variable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.0.0
    • Component/s: Code
    • Labels:
      None

      Description

      As you're currently switching to PHP5 OOP code, I would suggest to replace this ugly global constant by a static attribute of the LogManager class i.e. LogManager::$configFile = ... Or maybe even a constructor/factory argument
      This would have the additional benefit that it could be set by some kind of Dependency Injection framework like Spring for Java, although I don't know of such is even existing for PHP But it might come in the future.

        Activity

        Christian Brunotte created issue -
        Christian Grobmeier made changes -
        Field Original Value New Value
        Fix Version/s 2.0 [ 12313916 ]
        Christian Grobmeier made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ivan Habunek made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Christian Brunotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development