Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      PHP5.2.5

      Description

      While I was looking around the files, I found that the files contains unwanted trailing "\n". The files should end with "?>" and not "?>\n".

      If we have a trailing \n, php will send a "\n" as a content, and this cause some functions such as header(), won't work properly.

      Another style may be a Zend Framework style that doesn't have ending "?>".
      http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html#coding-standard.php-file-formatting.general

      ---------------------
      I got a feedback about this at log4php-dev@logging.apache.org, that we prefer
      zend-framework style formatting from Curt Arnold <carnold_at_apache.org> and "Michael Gall" <michael_at_wakeless.net>.

        Activity

        Hide
        Hiroaki Kawai added a comment -

        This patch will remove PHP closing tags.

        Show
        Hiroaki Kawai added a comment - This patch will remove PHP closing tags.
        Hide
        Curt Arnold added a comment -

        Committed rev 635069.

        Running "mvn test" didn't look clean, but it didn't look clean before the patch either.

        Show
        Curt Arnold added a comment - Committed rev 635069. Running "mvn test" didn't look clean, but it didn't look clean before the patch either.

          People

          • Assignee:
            Unassigned
            Reporter:
            Hiroaki Kawai
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development