Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.1.0
    • Component/s: Code
    • Labels:
      None

      Description

      http://ci.apache.org/projects/log4php/coverage-report/LoggerNDC.php.html

      Nested contexts are on a per thread basis. Does this make sense for PHP? If yes, there are methods named in the docs which do not exist (getNDC). Also there are still global variables and a lack of test cases.

        Activity

        Hide
        juice Ivan Habunek added a comment -

        I think this class makes perfect sense, it's just not per-thread, but per-process. Maybe someone could try it out with pcntl, i'm running on windows.

        Show
        juice Ivan Habunek added a comment - I think this class makes perfect sense, it's just not per-thread, but per-process. Maybe someone could try it out with pcntl, i'm running on windows.
        Hide
        juice Ivan Habunek added a comment -

        I have refactored the class to use a private variable for storage and added tests.
        Committed in revision 998456.

        Show
        juice Ivan Habunek added a comment - I have refactored the class to use a private variable for storage and added tests. Committed in revision 998456.

          People

          • Assignee:
            juice Ivan Habunek
            Reporter:
            cgrobmeier Christian Grobmeier
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development