Log4net
  1. Log4net
  2. LOG4NET-60

Bug in RollingFileAppender.cs causing failure to timely roll files on monthly interval

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.9
    • Fix Version/s: 1.2.10
    • Component/s: Appenders
    • Labels:
      None

      Description

      code in said file looks like this

      case RollPoint.TopOfMonth:
      current = current.AddMilliseconds(-current.Millisecond);
      current = current.AddSeconds(-current.Second);
      current = current.AddMinutes(-current.Minute);
      current = current.AddHours(-current.Hour);
      current = current.AddMonths(1);
      break;

      i belive it should look something like this

      case RollPoint.TopOfMonth:
      current = current.AddMilliseconds(-current.Millisecond);
      current = current.AddSeconds(-current.Second);
      current = current.AddMinutes(-current.Minute);
      current = current.AddHours(-current.Hour);
      current = current.AddDays(1 - current.Day); // this line seems to be needed
      current = current.AddMonths(1);
      break;

      also in a separate issue, since there is no RollPoint.TopOfYear, this comment in another part of the code seems wrong:

      //is the new file name equivalent to the 'current' one
      //something has gone wrong if we hit this – we should only
      //roll over if the new file will be different from the old
      string dateFormat = m_now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo);
      if (m_scheduledFilename.Equals(File + dateFormat))

      { ErrorHandler.Error("Compare " + m_scheduledFilename + " : " + File + dateFormat); return; }

      if the date pattern specifies only the year (rolling yearly), then i think this "error" will be triggered incorrectly 11 times a year. it's fine not to roll, but reporting an error is inappropriate.

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Nicko Cadell
            Reporter:
            Lanchon
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development