[LOG4NET-571] Rolling by size, Preserve Extension, and Folder don't work together

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.0.8
• Component/s: Appenders
• Assignee: Unassigned
• Reporter: EbenZhang
• Created: 27/Jul/17 13:11
• Updated: 04/Apr/20 22:29

Description

Those three don't work well together, the oldest file won't be deleted, e.g.

<appender name="MyAppender" type="log4net.Appender.RollingFileAppender">
      <file type="log4net.Util.PatternString" value="SomeFolder\myLog.txt" />
      <appendToFile value="true" />
      <rollingStyle value="size" />
      <maximumFileSize value="2KB"/>
      <maxSizeRollBackups value="10"/>
      <countDirection value="1"/>
      <preserveLogFileNameExtension value="true"/>
      <staticLogFileName value="false" />
</appender>

Because in RollingFileAppender line 1496, the folder will be stripped, as a result the code is unable to find the file to delete.

string extension = Path.GetExtension(archiveFileBaseName);
string baseName = Path.GetFileNameWithoutExtension(archiveFileBaseName);
int lastDotIndex = baseName.LastIndexOf(".");
if (lastDotIndex >= 0)
{
    archiveFileBaseName = baseName.Substring(0, lastDotIndex) + extension;
}

Issue Links

• links to: GitHub Pull Request #13