Uploaded image for project: 'Log4net'
  1. Log4net
  2. LOG4NET-554

LogicalThreadContext was removed in .NETStandard

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.0.7
    • Fix Version/s: 2.0.8
    • Component/s: Builds
    • Labels:
      None
    • Environment:
      .NETStandard1.3

      Description

      LogicalThreadContext was excluded from dotnetcore version due to System.Runtime.Remoting.Messaging no longer being available going forward.

        Issue Links

          Activity

          Hide
          bodewig Stefan Bodewig added a comment -

          True. This is why it is excluded from the build that targets netstandard-1.3.

          What do you want us to change?

          Show
          bodewig Stefan Bodewig added a comment - True. This is why it is excluded from the build that targets netstandard-1.3. What do you want us to change?
          Hide
          twcclegg Thomas Clegg added a comment -

          My team's use case is highly dependent on this functionality and as such we obviously don't want to lose it. The same functionality should be available via AsyncLocal<T> which is supported in .NET 4.6 and above. I'm actively working on a patch to get things working again.

          Show
          twcclegg Thomas Clegg added a comment - My team's use case is highly dependent on this functionality and as such we obviously don't want to lose it. The same functionality should be available via AsyncLocal<T> which is supported in .NET 4.6 and above. I'm actively working on a patch to get things working again.
          Hide
          nachbarslumpi Dominik Psenner added a comment -

          Interesting, I look forward seeing a patch!

          Show
          nachbarslumpi Dominik Psenner added a comment - Interesting, I look forward seeing a patch!
          Hide
          bodewig Stefan Bodewig added a comment -

          Thank you

          Show
          bodewig Stefan Bodewig added a comment - Thank you
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user twcclegg opened a pull request:

          https://github.com/apache/log4net/pull/42

          LOG4NET-554 Use AsyncLocal for LogicalThreadContext

          Replaces System.Runtime.Remoting.Messaging.CallContext which was removed in .NETStandard, with System.Threading.AsyncLocal which exists in .NET 4.6 and above

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/twcclegg/log4net-1 AsyncLocal4

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/log4net/pull/42.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #42


          commit 53d435577890ef9a68b8929acead75301be9151a
          Author: Thomas Clegg <tclegg@godaddy.com>
          Date: 2017-02-27T20:37:50Z

          LOG4NET-554 Use AsyncLocal for LogicalThreadContext

          commit cdcf231b028db599ff9f04705dc9ca1a0ecb17a0
          Author: Thomas Clegg <tclegg@godaddy.com>
          Date: 2017-02-27T21:14:44Z

          remove LogicalThreadContext from not supported list


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user twcclegg opened a pull request: https://github.com/apache/log4net/pull/42 LOG4NET-554 Use AsyncLocal for LogicalThreadContext Replaces System.Runtime.Remoting.Messaging.CallContext which was removed in .NETStandard, with System.Threading.AsyncLocal which exists in .NET 4.6 and above You can merge this pull request into a Git repository by running: $ git pull https://github.com/twcclegg/log4net-1 AsyncLocal4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit 53d435577890ef9a68b8929acead75301be9151a Author: Thomas Clegg <tclegg@godaddy.com> Date: 2017-02-27T20:37:50Z LOG4NET-554 Use AsyncLocal for LogicalThreadContext commit cdcf231b028db599ff9f04705dc9ca1a0ecb17a0 Author: Thomas Clegg <tclegg@godaddy.com> Date: 2017-02-27T21:14:44Z remove LogicalThreadContext from not supported list
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/log4net/pull/42

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/log4net/pull/42
          Hide
          bodewig Stefan Bodewig added a comment -

          Many thanks, Thomas. I've merged your pull request.

          Show
          bodewig Stefan Bodewig added a comment - Many thanks, Thomas. I've merged your pull request.

            People

            • Assignee:
              Unassigned
              Reporter:
              twcclegg Thomas Clegg
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 504h
                504h
                Remaining:
                Remaining Estimate - 504h
                504h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development