Uploaded image for project: 'Log4net'
  1. Log4net
  2. LOG4NET-486

Rolling File Appender with 'maxSizeRollBackups' and 'datePattern' does not detect existing logs initially

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.13
    • Fix Version/s: 1.2.14
    • Component/s: Appenders
    • Labels:
    • Environment:
      Windows 8, Visual Studio 2013
    • Flags:
      Important

      Description

      Rolling file appender with 'maxSizeRollBackups' set to a positive number tries to initialise by looking at existing log files to continue the rolling sequence and set 'm_curSizeRollBackups' to its correct value but the base filename format is wrong.

      In method GetWildcardPatternForFile with m_preserveLogFileNameExtension true it should construct a wildcard pattern but the 'baseFileName' is not enough to fully identify the log file when 'datePattern' is also specified.

      For example: -

      With log files such as: -

      MyLogFile_2015-10-27.1.log
      MyLogFile_2015-10-27.2.log

      the pattern created is 'MyLogFile.*.log'

      The date pattern is missing and as a result no log files are found and historical log files get overwritten rather than rolled over.

      A quick fix I'm using is to remove the '.' from the literal ".*" in the wildcard. This allows the OS to identify the log files. Later code makes a fuller check of the exact log file format and therefore this may be safe but I would think it needs more validation and testing to be sure this works under all circumstances.

        Attachments

          Activity

            People

            • Assignee:
              nachbarslumpi Dominik Psenner
              Reporter:
              SimonClark100 Simon Clark
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified