[LOG4NET-437] LogicalThreadContext data does not flow properly using Async and Await

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.9, 1.2.10, 1.2.11, 1.2.12, 1.2.13
• Fix Version/s: 1.3.0
• Component/s: Core
• Environment: Windows 7, .NET 4.5
• Assignee: Unassigned
• Reporter: Mike Barry
• Created: 20/Aug/14 13:40
• Updated: 31/Mar/15 12:33
• Resolved: 31/Mar/15 12:33

Description

LogicalThreadContext doesn't work properly when using Async and Await. The current NDC call stack gets corrupted because the logical data context is not immutable. (See: http://blog.stephencleary.com/2013/04/implicit-async-context-asynclocal.html for the gory details). I've attached a Program.cs that demonstrates the issue. You will see with an unpatched log4net the thread context is corrupted compared to the proper implementation in MyStack and the console logger. An entry like:

LOG4NET Main 1 A 2 A: </MoreWork>
LOG4NET Main 1 A 2 A: </MoreWork>

is invalid and should not be possible in a properly working thread context.

I've attached a VERY naive patch that corrects the issue.

Issue Links

• duplicates: LOG4NET-455 LogicalThreadContext does not flow correctly through async/await