[LOG4NET-291] RollingFileAppender not working correctly when using DatePattern containing >= 1 uppercase character in date format string literal

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.2.9, 1.2.10, 1.2.11
• Fix Version/s: 1.2/2.0 Maintenance Release
• Component/s: Appenders
• Labels: bug
• Environment: N.A.
• Assignee: Unassigned
• Reporter: Lee Chun Kit
• Created: 06/Apr/11 05:37
• Updated: 04/Apr/20 22:30

Description

When using RollingFileAppender with a DatePattern containing at least 1 uppercase character in the form of a string literal, rolling of log files does not take place correctly. This is as "curFileName" is a lowercase string.

To reproduce, see: http://mail-archives.apache.org/mod_mbox/logging-log4net-user/201104.mbox/%3CBANLkTi=[e-mail]%3E

Suggest change/fix to RollingFileAppender.cs:

1.2.9:
793c793
< if (! curFileName.StartsWith(baseFile + m_dateTime.Now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo)))
—
> if (! curFileName.StartsWith(baseFile + m_dateTime.Now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo).ToLower(System.Globalization.CultureInfo.InvariantCulture)))

1.2.10
816c816
< if (! curFileName.StartsWith(baseFile + m_dateTime.Now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo)))
—
> if (! curFileName.StartsWith(baseFile + m_dateTime.Now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo).ToLower(System.Globalization.CultureInfo.InvariantCulture)))

Trunk:
885c885
< if (! curFileName.StartsWith(CombinePath(baseFile, m_dateTime.Now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo))))
—
> if (! curFileName.StartsWith(CombinePath(baseFile, m_dateTime.Now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo).ToLower(System.Globalization.CultureInfo.InvariantCulture))))

Work-about:
Don't use uppercase characters in the form of a string literal for RollingFileAppender.DatePattern.