[LOG4NET-148] ThreadContext uses LocalDataStore to store ThreadSpecific data instead should be using [ThreadStatic] variables.

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.2.9, 1.2.10
• Fix Version/s: 1.2.12
• Component/s: Core
• Environment: .Net Framework
• Assignee: Dominik Psenner
• Reporter: Hernando Torres-Rocca
• Created: 22/Apr/08 15:25
• Updated: 05/Jun/13 15:03
• Resolved: 05/Jun/13 15:03

Description

According to this article (http://blogs.msdn.com/junfeng/archive/2005/12/31/508423.aspx) and production issues encountered: using LocalDataStore is not a scalable approach for any web server that gets a significant amount of traffic.

The ThreadContext object should be modified to use [ThreadStatic] variables.

From the article:
The Whidbey RTM implementation of Thread.GetData/Thread.SetData has several scalability issues caused by global locks being taken. The appdomain-global lock taken in LocalDataStore.SetData is one of them. There is another global lock taken in ThreadNative::GetDomainLocalStore that is even worse since it is process-global.

The best workaround is to use [ThreadStatic] variables instead of Thread.GetData/Thread.SetData