Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-585

Markers not as powerful as slf4j



    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0-rc1
    • 2.0-rc2
    • API
    • None


      Log4J's markers are not as flexible as markers in SLF4J.

      First, SLF4J's markers are mutable. By allowing markers to be mutable, I can change the relationship of markers to each other based upon runtime or business conditions.

      Second, and more importantly I think, is that essentially SLF4J markers have this parent/child relationship, much like Log4J, except that in SLF4J, I can essentially have a marker with multiple parents. For example, I might want this structure:

      • Animal
        • Bird
          • Duck
        • Mammal
          • Bear
          • Dolphin
      • Travels by
        • Water
          • Duck
          • Dolphin
        • Land
          • Duck
          • Bear
        • Air
          • Duck

      Of course, this is a contrived example, but I wanted to describe the relationships. Now, if I wanted to filter based on markers that travel by Water for some appenders, and another appender wants to filter by Mammals, I can't simply use the single marker of Dolphin.

      Either we need to reverse the marker relationship so that it contains its children, much like SLF4J, or we allow markers to have multiple parents, which I prefer because it could make it more succinct to define:

      private static final Marker BY_LAND = MarkerManager.getMarker("BY_LAND");
      private static final Marker BY_WATER = MarkerManager.getMarker("BY_WATER");
      private static final Marker DUCK = MarkerManager.getMarker("DUCK", BY_LAND, BY_WATER);

      As for the Marker API, we would either need to change getParent to getParents, or get rid of the getParent method from the API and just rely on the isInstanceOf method to handle checking multiple parents by looking at private member variables (my preference)


        1. CurrentMarkerBenchmark.java
          2 kB
          Bruce Brouwer
        2. ConceptMarkerBenchmark.java
          2 kB
          Bruce Brouwer
        3. log4j2-585-concept.patch
          50 kB
          Bruce Brouwer



            Unassigned Unassigned
            bruce.brouwer Bruce Brouwer
            0 Vote for this issue
            3 Start watching this issue